From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Skeggs <bskeggs@redhat.com>
Date: Thu, 03 Jun 2010 01:22:57 +0000
Subject: Re: [patch] drm/nouveau: off by one in init_i2c_device_find()
Message-Id: <1275528177.9064.0.camel@nisroch>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20100525095227.GH22515@bicker>
In-Reply-To: <20100525095227.GH22515@bicker>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org

On Tue, 2010-05-25 at 11:52 +0200, Dan Carpenter wrote:
> dcb->i2c[] has DCB_MAX_NUM_I2C_ENTRIES entries.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks, picked this up in the nouveau tree.

> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index e7e69cc..bf92a1e 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -814,7 +814,7 @@ init_i2c_device_find(struct drm_device *dev, int i2c_index)
>  	if (i2c_index = 0x81)
>  		i2c_index = (dcb->i2c_default_indices & 0xf0) >> 4;
>  
> -	if (i2c_index > DCB_MAX_NUM_I2C_ENTRIES) {
> +	if (i2c_index >= DCB_MAX_NUM_I2C_ENTRIES) {
>  		NV_ERROR(dev, "invalid i2c_index 0x%x\n", i2c_index);
>  		return NULL;
>  	}