From: Joe Perches <joe@perches.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Henk de Groot <pe1dnn@amsat.org>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/wlags49_hs: Fix build error when CONFIG_SYSFS
Date: Fri, 11 Jun 2010 16:52:36 +0000 [thread overview]
Message-ID: <1276275156.1637.52.camel@Joe-Laptop.home> (raw)
In-Reply-To: <AANLkTikH_CAVo7sblakUfhI-ysIXk2z1KZz0YkjCDL3m@mail.gmail.com>
On Fri, 2010-06-11 at 08:46 -0400, Javier Martinez Canillas wrote:
> >> extern void register_wlags_sysfs(struct net_device *);
> >> extern void unregister_wlags_sysfs(struct net_device *);
> >> #else
> >> -static void register_wlags_sysfs(struct net_device *) { return; };
> >> -static void unregister_wlags_sysfs(struct net_device *) { return; };
> >> +#define register_wlags_sysfs(net_device) { }
> >> +#define unregister_wlags_sysfs(net_device) { }
> >> #endif
> > Yes, that works, but a better fix would be to remove the
> > semicolons after the function close braces.
> > ---
> Why would it be better? With a macro you avoid the overhead of a
> function call that does nothing.
Check the generated code.
$ make drivers/staging/wlags49_h2/wl_sysfs.lst
> I personally think a macro fit better in this case.
Check the general kernel use of macros vs functions.
Functions verify proper arguments, macros do not.
next prev parent reply other threads:[~2010-06-11 16:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 6:35 [PATCH] staging/wlags49_hs: Fix build error when CONFIG_SYSFS is Javier Martinez Canillas
2010-06-11 6:41 ` [PATCH] staging/wlags49_hs: Fix build error when CONFIG_SYSFS Joe Perches
2010-06-11 12:46 ` [PATCH] staging/wlags49_hs: Fix build error when CONFIG_SYSFS is Javier Martinez Canillas
2010-06-11 16:52 ` Joe Perches [this message]
2010-06-11 22:12 ` Javier Martinez Canillas
2010-06-11 22:18 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276275156.1637.52.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=pe1dnn@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox