From: Joe Eloff <kagen101@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: ERROR: do not initialise externals to 0 or NULL
Date: Mon, 05 Jul 2010 21:13:12 +0000 [thread overview]
Message-ID: <1278364392.5396.52.camel@dermezel> (raw)
In-Reply-To: <1278346615.5396.3.camel@dermezel>
On Mon, 2010-07-05 at 22:48 +0200, Dan Carpenter wrote:
> On Mon, Jul 05, 2010 at 10:45:20PM +0200, Dan Carpenter wrote:
> > /* Error variable. Zero means no error. */
> > int dt3155_errno;
> >
> > But really this global variable is pretty ugly. It would be better to
> > eliminate it. You would have to modify wait_ibsyclr() somehow...
> >
>
> The variable gets assigned but never used. Maybe try figure out if that
> means there is a larger bug, otherwise you can just removed it entirely.
>
> > regards,
> > dan carpenter
Saw that it never gets used but assigned as looking into it.
Regards,
Joe
next prev parent reply other threads:[~2010-07-05 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 16:16 ERROR: do not initialise externals to 0 or NULL Joe Eloff
2010-07-05 19:36 ` Dan Carpenter
2010-07-05 20:03 ` Julia Lawall
2010-07-05 20:19 ` Joe Eloff
2010-07-05 20:45 ` Dan Carpenter
2010-07-05 20:48 ` Dan Carpenter
2010-07-05 20:53 ` Joe Eloff
2010-07-05 21:13 ` Joe Eloff [this message]
2010-07-05 21:17 ` Dan Carpenter
2010-07-05 21:21 ` Joe Eloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278364392.5396.52.camel@dermezel \
--to=kagen101@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox