From: Alex Elder <aelder@sgi.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
Date: Tue, 20 Jul 2010 19:35:33 +0000 [thread overview]
Message-ID: <1279654533.1859.242.camel@doink> (raw)
In-Reply-To: <20100715212116.GA7013@infradead.org>
On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote:
> On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> > map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> > below zero. So, check exact expression instead of map_len.
> >
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
Looks good to me too. Do you want me to pull this
in via the XFS tree, or do you have other plans?
-Alex
next prev parent reply other threads:[~2010-07-20 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:46 [PATCH 6/8] xfs: fix unsigned underflow Kulikov Vasiliy
2010-07-15 21:21 ` Christoph Hellwig
2010-07-20 19:35 ` Alex Elder [this message]
2010-07-20 20:21 ` Vasiliy Kulikov
2010-07-20 23:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279654533.1859.242.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).