* [PATCH] staging/rt2860: fix bad dma_addr_t conversion
@ 2010-08-04 4:45 Javier Martinez Canillas
2010-08-04 5:11 ` FUJITA Tomonori
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2010-08-04 4:45 UTC (permalink / raw)
To: Greg Kroah-Hartman, Bartlomiej Zolnierkiewicz, Ben Hutchings,
Gorskin Ilya, devel, linux-kernel, kernel-janitors
DMA addresses are not pointers and shouldn't be assigned to NULL.
This patch was generated against today linux-next.
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
drivers/staging/rt2860/rt_pci_rbus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rt2860/rt_pci_rbus.c b/drivers/staging/rt2860/rt_pci_rbus.c
index 3004be6..244c754 100644
--- a/drivers/staging/rt2860/rt_pci_rbus.c
+++ b/drivers/staging/rt2860/rt_pci_rbus.c
@@ -218,7 +218,7 @@ void *RTMP_AllocateRxPacketBuffer(struct rt_rtmp_adapter *pAd,
PCI_DMA_FROMDEVICE);
} else {
*VirtualAddress = (void *)NULL;
- *PhysicalAddress = (dma_addr_t)NULL;
+ *PhysicalAddress = 0;
}
return (void *)pkt;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging/rt2860: fix bad dma_addr_t conversion
2010-08-04 4:45 [PATCH] staging/rt2860: fix bad dma_addr_t conversion Javier Martinez Canillas
@ 2010-08-04 5:11 ` FUJITA Tomonori
0 siblings, 0 replies; 2+ messages in thread
From: FUJITA Tomonori @ 2010-08-04 5:11 UTC (permalink / raw)
To: martinez.javier
Cc: gregkh, bzolnier, ben, revent82, devel, linux-kernel,
kernel-janitors
On Wed, 04 Aug 2010 00:45:19 -0400
Javier Martinez Canillas <martinez.javier@gmail.com> wrote:
> DMA addresses are not pointers and shouldn't be assigned to NULL.
> This patch was generated against today linux-next.
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> drivers/staging/rt2860/rt_pci_rbus.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/rt2860/rt_pci_rbus.c b/drivers/staging/rt2860/rt_pci_rbus.c
> index 3004be6..244c754 100644
> --- a/drivers/staging/rt2860/rt_pci_rbus.c
> +++ b/drivers/staging/rt2860/rt_pci_rbus.c
> @@ -218,7 +218,7 @@ void *RTMP_AllocateRxPacketBuffer(struct rt_rtmp_adapter *pAd,
> PCI_DMA_FROMDEVICE);
> } else {
> *VirtualAddress = (void *)NULL;
> - *PhysicalAddress = (dma_addr_t)NULL;
> + *PhysicalAddress = 0;
> }
This doesn't look correct since zero is a valid DMA address on some
architectures.
I recommend removing the else part completely. If you need to mark a
rx buffer invalid, adding a flag to the rx descriptor structure of a
driver is a popular way (see other network drivers, e.g. bnx2).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-04 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-04 4:45 [PATCH] staging/rt2860: fix bad dma_addr_t conversion Javier Martinez Canillas
2010-08-04 5:11 ` FUJITA Tomonori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox