From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Date: Sun, 08 Aug 2010 10:25:07 +0000 Subject: Re: [PATCH 2/2] drivers/mtd/ubi: Eliminate update of Message-Id: <1281263107.2384.13.camel@localhost> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Julia Lawall Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, David Woodhouse , linux-kernel@vger.kernel.org On Sat, 2010-08-07 at 11:09 +0200, Julia Lawall wrote: > From: Julia Lawall > > list_for_each_entry uses its first argument to move from one element to the > next, so modifying it can break the iteration. The variable re1 is already > used within the loop as a temporary variable, and is not live here. Looks good, thanks, I'll push it to the UBI tree a bit later. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)