From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <error27@gmail.com>
Cc: Dan Williams <dcbw@redhat.com>,
"John W. Linville" <linville@tuxdriver.com>,
Ben Hutchings <ben@decadent.org.uk>,
Mike Frysinger <vapier.adi@gmail.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [rfc patch] libertas: fix if_spi_prog_helper_firmware()
Date: Tue, 24 Aug 2010 12:17:52 +0000 [thread overview]
Message-ID: <1282652273.3695.21.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100824120743.GG29330@bicker>
On Tue, 2010-08-24 at 14:07 +0200, Dan Carpenter wrote:
> The indenting is not correct here. I don't have this hardware and I'm
> just guessing as to what was intended. I think that if there is an
> error we should return an error code, but if there isn't an error we
> should return success directly without releasing the firmware.
> goto release_firmware;
> err = spu_write_u16(card, IF_SPI_CARD_INT_CAUSE_REG,
> IF_SPI_CIC_CMD_DOWNLOAD_OVER);
> + if (err)
> goto release_firmware;
>
> - lbs_deb_spi("waiting for helper to boot...\n");
> + lbs_deb_spi("helper firmware loaded...\n");
> +
> + return 0;
>
> release_firmware:
> release_firmware(firmware);
This doesn't look correct, the caller of this function also sometimes
releases the firmware, but it looks like it could lead to a double-free?
johannes
next prev parent reply other threads:[~2010-08-24 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 12:07 [rfc patch] libertas: fix if_spi_prog_helper_firmware() Dan Carpenter
2010-08-24 12:15 ` Ben Hutchings
2010-08-26 3:26 ` Colin McCabe
2010-08-26 3:37 ` Ben Hutchings
2010-08-26 17:04 ` Colin McCabe
2010-08-24 12:17 ` Johannes Berg [this message]
2010-08-26 15:48 ` Dan Williams
2010-08-26 18:52 ` Paul Fox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282652273.3695.21.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ben@decadent.org.uk \
--cc=dcbw@redhat.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox