From: Kulikov Vasiliy <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Vasiliy Kulikov <segooon@gmail.com>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 01/14] avr32/mach-at32ap/clock: check return code of clk_get
Date: Sun, 05 Sep 2010 18:32:15 +0000 [thread overview]
Message-ID: <1283711535-7082-1-git-send-email-segooon@gmail.com> (raw)
From: Vasiliy Kulikov <segooon@gmail.com>
Function clk_get may return ERR_PTR(...). Check for it.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
arch/avr32/mach-at32ap/clock.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/avr32/mach-at32ap/clock.c b/arch/avr32/mach-at32ap/clock.c
index 442f08c..133a475 100644
--- a/arch/avr32/mach-at32ap/clock.c
+++ b/arch/avr32/mach-at32ap/clock.c
@@ -258,14 +258,20 @@ static int clk_show(struct seq_file *s, void *unused)
/* show clock tree as derived from the three oscillators */
clk = clk_get(NULL, "osc32k");
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);
dump_clock(clk, &r);
clk_put(clk);
clk = clk_get(NULL, "osc0");
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);
dump_clock(clk, &r);
clk_put(clk);
clk = clk_get(NULL, "osc1");
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);
dump_clock(clk, &r);
clk_put(clk);
--
1.7.0.4
reply other threads:[~2010-09-05 18:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283711535-7082-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=hskinnemoen@atmel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox