public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH 7/8] drivers/i2c/busses/i2c-amd8111.c: Fix unsigned return type
Date: Sun, 05 Sep 2010 18:59:52 +0000	[thread overview]
Message-ID: <1283713226-8429-8-git-send-email-julia@diku.dk> (raw)

In each case, the function has an unsigned return type, but returns a
negative constant to indicate an error condition.  The result of calling
the function is always stored in a variable of type (signed) int, and thus
unsigned can be dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/i2c/busses/i2c-amd8111.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-amd8111.c b/drivers/i2c/busses/i2c-amd8111.c
index af1e5e2..02a3726 100644
--- a/drivers/i2c/busses/i2c-amd8111.c
+++ b/drivers/i2c/busses/i2c-amd8111.c
@@ -69,7 +69,7 @@ static struct pci_driver amd8111_driver;
  * ACPI 2.0 chapter 13 access of registers of the EC
  */
 
-static unsigned int amd_ec_wait_write(struct amd_smbus *smbus)
+static int amd_ec_wait_write(struct amd_smbus *smbus)
 {
 	int timeout = 500;
 
@@ -85,7 +85,7 @@ static unsigned int amd_ec_wait_write(struct amd_smbus *smbus)
 	return 0;
 }
 
-static unsigned int amd_ec_wait_read(struct amd_smbus *smbus)
+static int amd_ec_wait_read(struct amd_smbus *smbus)
 {
 	int timeout = 500;
 


             reply	other threads:[~2010-09-05 18:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-05 18:59 Julia Lawall [this message]
2010-09-08  5:58 ` [PATCH 7/8] drivers/i2c/busses/i2c-amd8111.c: Fix unsigned return Julia Lawall
     [not found]   ` <Pine.LNX.4.64.1009080757050.27892-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
2010-09-08  7:34     ` [PATCH 7/8] drivers/i2c/busses/i2c-amd8111.c: Fix unsigned Jean Delvare
     [not found]       ` <20100908093449.0adef429-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-09-08  9:48         ` [PATCH 7/8] drivers/i2c/busses/i2c-amd8111.c: Fix unsigned return Julia Lawall
2010-09-29 15:46           ` [PATCH 7/8] drivers/i2c/busses/i2c-amd8111.c: Fix unsigned Jean Delvare
     [not found]             ` <20100929174606.616e564c-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-09-29 19:47               ` [PATCH 7/8] drivers/i2c/busses/i2c-amd8111.c: Fix unsigned return Julia Lawall
     [not found]                 ` <Pine.LNX.4.64.1009292147060.25609-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
2010-09-30 20:27                   ` Julia Lawall
2010-10-01 13:21                     ` [PATCH 7/8] drivers/i2c/busses/i2c-amd8111.c: Fix unsigned Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283713226-8429-8-git-send-email-julia@diku.dk \
    --to=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox