From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Fri, 24 Sep 2010 01:18:18 +0000 Subject: [PATCH V3] git-send-email.perl: Add --to-cmd Message-Id: <1285291098.25928.220.camel@Joe-Laptop> List-Id: References: <1285227413.7286.47.camel@Joe-Laptop> <20100923090931.GA29789@albatros> <20100923120024.GA26715@albatros> <1285253867.31572.13.camel@Joe-Laptop> <1285262237.31572.18.camel@Joe-Laptop> <1285263993.31572.25.camel@Joe-Laptop> <1285267520.31572.34.camel@Joe-Laptop> <7v62xwqe7i.fsf@alter.siamese.dyndns.org> In-Reply-To: <7v62xwqe7i.fsf@alter.siamese.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Junio C Hamano Cc: =?ISO-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason , Julia Lawall , git , Vasiliy Kulikov , matt mooney , kernel-janitors@vger.kernel.org, Dan Carpenter Add the ability to use a command line --to-cmd=3Dcmd to create the list of "To:" addresses. Used a shared routine for --cc-cmd and --to-cmd. Did not use IPC::Open2, leaving that for =C3=86var if ever he decides to fix the other bugs he might find. Signed-off-by: Joe Perches --- Documentation/git-send-email.txt | 8 +++++- git-send-email.perl | 51 +++++++++++++++++++++++++---------= --- t/t9001-send-email.sh | 18 +++++++++++++ 3 files changed, 59 insertions(+), 18 deletions(-) diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-emai= l.txt index c283084..fff97a3 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -97,7 +97,7 @@ See the CONFIGURATION section for 'sendemail.multiedit'. Specify the primary recipient of the emails generated. Generally, this will be the upstream maintainer of the project involved. Default is the value of the 'sendemail.to' configuration value; if that is unspecified, - this will be prompted for. + and --to-cmd is not specified, this will be prompted for. + The --to option must be repeated for each user you want on the to list. =20 @@ -177,6 +177,12 @@ user is prompted for a password while the input is mas= ked for privacy. Automating ~~~~~~~~~~ =20 +--to-cmd=3D:: + Specify a command to execute once per patch file which + should generate patch file specific "To:" entries. + Output of this command must be single email address per line. + Default is the value of 'sendemail.tocmd' configuration value. + --cc-cmd=3D:: Specify a command to execute once per patch file which should generate patch file specific "Cc:" entries. diff --git a/git-send-email.perl b/git-send-email.perl index 6dab3bf..e148269 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -70,6 +70,7 @@ git send-email [options] =20 Automating: --identity * Use the sendemail. options. + --to-cmd * Email To: via ` \$patch_path` --cc-cmd * Email Cc: via ` \$patch_path` --suppress-cc * author, self, sob, cc, cccmd, body, b= odycc, all. --[no-]signed-off-by-cc * Send to Signed-off-by: addresses. Def= ault on. @@ -187,7 +188,8 @@ sub do_edit { } =20 # Variables with corresponding config settings -my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc, $cc_cmd); +my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc); +my ($to_cmd, $cc_cmd); my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption); my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts, $smtp_domai= n); my ($validate, $confirm); @@ -214,6 +216,7 @@ my %config_settings =3D ( "smtppass" =3D> \$smtp_authpass, "smtpdomain" =3D> \$smtp_domain, "to" =3D> \@to, + "tocmd" =3D> \$to_cmd, "cc" =3D> \@initial_cc, "cccmd" =3D> \$cc_cmd, "aliasfiletype" =3D> \$aliasfiletype, @@ -272,6 +275,7 @@ my $rc =3D GetOptions("sender|from=3Ds" =3D> \$sender, "in-reply-to=3Ds" =3D> \$initial_reply_to, "subject=3Ds" =3D> \$initial_subject, "to=3Ds" =3D> \@to, + "to-cmd=3Ds" =3D> \$to_cmd, "no-to" =3D> \$no_to, "cc=3Ds" =3D> \@initial_cc, "no-cc" =3D> \$no_cc, @@ -711,7 +715,7 @@ if (!defined $sender) { $prompting++; } =20 -if (!@to) { +if (!@to && !defined $to_cmd) { my $to =3D ask("Who should the emails be sent to? "); push @to, parse_address_line($to) if defined $to; # sanitized/validated l= ater $prompting++; @@ -1238,21 +1242,10 @@ foreach my $t (@files) { } close F; =20 - if (defined $cc_cmd && !$suppress_cc{'cccmd'}) { - open(F, "$cc_cmd \Q$t\E |") - or die "(cc-cmd) Could not execute '$cc_cmd'"; - while() { - my $c =3D $_; - $c =3D~ s/^\s*//g; - $c =3D~ s/\n$//g; - next if ($c eq $sender and $suppress_from); - push @cc, $c; - printf("(cc-cmd) Adding cc: %s from: '%s'\n", - $c, $cc_cmd) unless $quiet; - } - close F - or die "(cc-cmd) failed to close pipe to '$cc_cmd'"; - } + push @to, recipients_cmd("to-cmd", "to", $to_cmd, $t) + if defined $to_cmd; + push @cc, recipients_cmd("cc-cmd", "cc", $cc_cmd, $t) + if defined $cc_cmd && !$suppress_cc{'cccmd'}; =20 if ($broken_encoding{$t} && !$has_content_type) { $has_content_type =3D 1; @@ -1310,6 +1303,30 @@ foreach my $t (@files) { $message_id =3D undef; } =20 +# Execute a command (ie: $to_cmd) to get a list of email addresses +# and return a results array +sub recipients_cmd(@) { + my ($prefix, $what, $cmd, $file) =3D @_; + + my $sanitized_sender =3D sanitize_address($sender); + my @addresses =3D (); + open(F, "$cmd \Q$file\E |") + or die "($prefix) Could not execute '$cmd'"; + while() { + my $address =3D $_; + $address =3D~ s/^\s*//g; + $address =3D~ s/\n$//g; + $address =3D sanitize_address($address); + next if ($address eq $sanitized_sender and $suppress_from); + push @addresses, $address; + printf("($prefix) Adding %s: %s from: '%s'\n", + $what, $address, $cmd) unless $quiet; + } + close F + or die "($prefix) failed to close pipe to '$cmd'"; + return @addresses; +} + cleanup_compose_files(); =20 sub cleanup_compose_files() { diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 71b3df9..36cf421 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -201,6 +201,24 @@ test_expect_success $PREREQ 'Prompting works' ' grep "^To: to@example.com\$" msgtxt1 ' =20 +test_expect_success $PREREQ 'tocmd works' ' + clean_fake_sendmail && + cp $patches tocmd.patch && + echo tocmd--tocmd@example.com >>tocmd.patch && + { + echo "#!$SHELL_PATH" + echo sed -n -e s/^tocmd--//p \"\$1\" + } > tocmd-sed && + chmod +x tocmd-sed && + git send-email \ + --from=3D"Example " \ + --to-cmd=3D./tocmd-sed \ + --smtp-server=3D"$(pwd)/fake.sendmail" \ + tocmd.patch \ + && + grep "^To: tocmd@example.com" msgtxt1 +' + test_expect_success $PREREQ 'cccmd works' ' clean_fake_sendmail && cp $patches cccmd.patch && -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html