* [PATCH] touchscreen: tnetv107x: fix input_device leak
@ 2010-09-26 8:59 Vasiliy Kulikov
2010-09-26 10:00 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Vasiliy Kulikov @ 2010-09-26 8:59 UTC (permalink / raw)
To: kernel-janitors
Cc: Dmitry Torokhov, Cyril Chemparathy, Kevin Hilman, linux-input,
linux-kernel
tsc_probe() calls input_free_device() on error, but tsc_remove()
doesn't.
---
drivers/input/touchscreen/tnetv107x-ts.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/input/touchscreen/tnetv107x-ts.c b/drivers/input/touchscreen/tnetv107x-ts.c
index cf1dba2..82d9a01 100644
--- a/drivers/input/touchscreen/tnetv107x-ts.c
+++ b/drivers/input/touchscreen/tnetv107x-ts.c
@@ -361,6 +361,7 @@ static int __devexit tsc_remove(struct platform_device *pdev)
input_unregister_device(ts->input_dev);
free_irq(ts->tsc_irq, ts);
+ input_free_device(ts->input_dev);
clk_put(ts->clk);
iounmap(ts->regs);
release_mem_region(ts->res->start, resource_size(ts->res));
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] touchscreen: tnetv107x: fix input_device leak
2010-09-26 8:59 [PATCH] touchscreen: tnetv107x: fix input_device leak Vasiliy Kulikov
@ 2010-09-26 10:00 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2010-09-26 10:00 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: kernel-janitors@vger.kernel.org, Cyril Chemparathy, Kevin Hilman,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
On Sep 26, 2010, at 1:59 AM, Vasiliy Kulikov <segooon@gmail.com> wrote:
> tsc_probe() calls input_free_device() on error, but tsc_remove()
> doesn't.
NAK. It is forbidden to call input_free_device() after unregister.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-26 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-26 8:59 [PATCH] touchscreen: tnetv107x: fix input_device leak Vasiliy Kulikov
2010-09-26 10:00 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox