From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasiliy Kulikov Date: Tue, 28 Sep 2010 17:49:38 +0000 Subject: [PATCH] statistics_write: ft1000: fix kernel info leak to userland Message-Id: <1285696178-5696-1-git-send-email-segooon@gmail.com> List-Id: References: <1285491593-325-1-git-send-email-segooon@gmail.com> In-Reply-To: <1285491593-325-1-git-send-email-segooon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Cc: Greg Kroah-Hartman , Marek Belisko , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org get_stat_data is not fully initialized before copy_to_user() call, e.g. LedStat is not always set. Signed-off-by: Vasiliy Kulikov --- drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c index 65087ce..467fd31 100644 --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c @@ -623,7 +623,7 @@ static int ft1000_ChIoctl (struct file *File, unsigned int Command, break; case IOCTL_GET_DSP_STAT_CMD: //DEBUG("FT1000:ft1000_ChIoctl: IOCTL_FT1000_GET_DSP_STAT called\n"); - + memset(get_stat_data, 0, sizeof(get_stat_data)); memcpy(get_stat_data.DspVer, info->DspVer, DSPVERSZ); memcpy(get_stat_data.HwSerNum, info->HwSerNum, HWSERNUMSZ); memcpy(get_stat_data.Sku, info->Sku, SKUSZ); -- 1.7.0.4