* [PATCH] ipc: shm: fix information leak to userland
@ 2010-10-30 9:04 Vasiliy Kulikov
2010-10-30 9:06 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30 9:04 UTC (permalink / raw)
To: kernel-janitors
Cc: Al Viro, Andrew Morton, Helge Deller, David Howells, Hugh Dickins,
linux-kernel
Structure shmid_ds is copied to userland with shm_unused{,2,3}
fields unitialized. It leads to leaking of contents of kernel stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
ipc/shm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index fd658a1..7d3bb22 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
{
struct shmid_ds out;
+ memset(&out, 0, sizeof(out));
ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
out.shm_segsz = in->shm_segsz;
out.shm_atime = in->shm_atime;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipc: shm: fix information leak to userland
2010-10-30 9:04 [PATCH] ipc: shm: fix information leak to userland Vasiliy Kulikov
@ 2010-10-30 9:06 ` Al Viro
2010-10-30 14:22 ` Vasiliy Kulikov
0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2010-10-30 9:06 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: kernel-janitors, Andrew Morton, Helge Deller, David Howells,
Hugh Dickins, linux-kernel
On Sat, Oct 30, 2010 at 01:04:37PM +0400, Vasiliy Kulikov wrote:
> Structure shmid_ds is copied to userland with shm_unused{,2,3}
> fields unitialized. It leads to leaking of contents of kernel stack memory.
ACK; send to Linus and add Cc: stable@kernel.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ipc: shm: fix information leak to userland
2010-10-30 9:06 ` Al Viro
@ 2010-10-30 14:22 ` Vasiliy Kulikov
0 siblings, 0 replies; 3+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30 14:22 UTC (permalink / raw)
To: Linus Torvalds
Cc: kernel-janitors, Andrew Morton, Helge Deller, David Howells,
Hugh Dickins, linux-kernel
Structure shmid_ds is copied to userland with shm_unused{,2,3}
fields unitialized. It leads to leaking of contents of kernel stack
memory.
Cc: stable@kernel.org
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
ipc/shm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index fd658a1..7d3bb22 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
{
struct shmid_ds out;
+ memset(&out, 0, sizeof(out));
ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
out.shm_segsz = in->shm_segsz;
out.shm_atime = in->shm_atime;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-30 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-30 9:04 [PATCH] ipc: shm: fix information leak to userland Vasiliy Kulikov
2010-10-30 9:06 ` Al Viro
2010-10-30 14:22 ` Vasiliy Kulikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox