From: Vasiliy Kulikov <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"André Goddard Rosa" <andre.goddard@gmail.com>,
"Joe Perches" <joe@perches.com>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Bjorn Helgaas" <bjorn.helgaas@hp.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] lib: vsprintf: fix invalid arg check
Date: Wed, 10 Nov 2010 20:38:08 +0000 [thread overview]
Message-ID: <1289421490-23950-1-git-send-email-segooon@gmail.com> (raw)
"size" is size_t. If we want to check whether it was underflowed
then we should cast it to ssize_t instead of int. When
sizeof(size_t) > sizeof(int) the code sees UINT_MAX as underflow,
but it is not.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
lib/vsprintf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index c150d3d..e7cf674 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1290,7 +1290,7 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
/* Reject out-of-range values early. Large positive sizes are
used for unknown buffer sizes. */
- if (WARN_ON_ONCE((int) size < 0))
+ if (WARN_ON_ONCE((ssize_t) size < 0))
return 0;
str = buf;
--
1.7.0.4
next reply other threads:[~2010-11-10 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 20:38 Vasiliy Kulikov [this message]
2010-11-10 21:08 ` [PATCH] lib: vsprintf: fix invalid arg check Andrew Morton
2010-11-10 21:38 ` David Rientjes
2010-11-11 8:34 ` Vasiliy Kulikov
2010-11-11 20:38 ` David Rientjes
2010-11-11 21:02 ` Vasiliy Kulikov
2010-11-11 21:34 ` David Rientjes
2010-11-12 17:42 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289421490-23950-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andre.goddard@gmail.com \
--cc=bjorn.helgaas@hp.com \
--cc=fweisbec@gmail.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox