* [PATCH] arm: plat-spear: time: use IS_ERR() instead of NULL check
@ 2010-11-26 17:06 Vasiliy Kulikov
2010-11-29 6:44 ` viresh kumar
0 siblings, 1 reply; 2+ messages in thread
From: Vasiliy Kulikov @ 2010-11-26 17:06 UTC (permalink / raw)
To: linux-arm-kernel
clk_get() returns ERR_PTR() on error, not NULL.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
Cannot compile this driver, so it is not tested at all.
arch/arm/plat-spear/time.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-spear/time.c b/arch/arm/plat-spear/time.c
index ab21165..678df18 100644
--- a/arch/arm/plat-spear/time.c
+++ b/arch/arm/plat-spear/time.c
@@ -229,13 +229,13 @@ void __init spear_setup_timer(void)
}
gpt_clk = clk_get_sys("gpt0", NULL);
- if (!gpt_clk) {
+ if (IS_ERR(gpt_clk)) {
pr_err("%s:couldn't get clk for gpt\n", __func__);
goto err_iomap;
}
pll3_clk = clk_get(NULL, "pll3_48m_clk");
- if (!pll3_clk) {
+ if (IS_ERR(pll3_clk)) {
pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
goto err_iomap;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: plat-spear: time: use IS_ERR() instead of NULL check
2010-11-26 17:06 [PATCH] arm: plat-spear: time: use IS_ERR() instead of NULL check Vasiliy Kulikov
@ 2010-11-29 6:44 ` viresh kumar
0 siblings, 0 replies; 2+ messages in thread
From: viresh kumar @ 2010-11-29 6:44 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 26, 2010 at 10:36 PM, Vasiliy Kulikov <segoon@openwall.com> wrote:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile this driver, so it is not tested at all.
>
> arch/arm/plat-spear/time.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-spear/time.c b/arch/arm/plat-spear/time.c
> index ab21165..678df18 100644
> --- a/arch/arm/plat-spear/time.c
> +++ b/arch/arm/plat-spear/time.c
> @@ -229,13 +229,13 @@ void __init spear_setup_timer(void)
> }
>
> gpt_clk = clk_get_sys("gpt0", NULL);
> - if (!gpt_clk) {
> + if (IS_ERR(gpt_clk)) {
> pr_err("%s:couldn't get clk for gpt\n", __func__);
> goto err_iomap;
> }
>
> pll3_clk = clk_get(NULL, "pll3_48m_clk");
> - if (!pll3_clk) {
> + if (IS_ERR(pll3_clk)) {
> pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
> goto err_iomap;
> }
Compiled & tested.
Acked-by: Viresh Kumar <viresh.kumar@st.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-29 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-26 17:06 [PATCH] arm: plat-spear: time: use IS_ERR() instead of NULL check Vasiliy Kulikov
2010-11-29 6:44 ` viresh kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox