From: Javier Martinez Canillas <martinez.javier@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH 2/4] staging: keucr: Use strncpy() instead of custom StringCopy() and some style cleanups
Date: Fri, 31 Dec 2010 09:19:22 +0000 [thread overview]
Message-ID: <1293787164-7056-3-git-send-email-martinez.javier@gmail.com> (raw)
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
drivers/staging/keucr/smilecc.c | 16 +++++++++-------
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/keucr/smilecc.c b/drivers/staging/keucr/smilecc.c
index daf322a..f4ff9ac 100644
--- a/drivers/staging/keucr/smilecc.c
+++ b/drivers/staging/keucr/smilecc.c
@@ -182,13 +182,15 @@ BYTE *buf;
BYTE *redundant_ecc;
BYTE *calculate_ecc;
{
- DWORD err;
-
- err=correct_data(buf,redundant_ecc,*(calculate_ecc+1),*(calculate_ecc),*(calculate_ecc+2));
- if (err=1) StringCopy(calculate_ecc,redundant_ecc,3);
- if (err=0 || err=1 || err=2)
- return(0);
- return(-1);
+ DWORD err;
+ err = correct_data(buf, redundant_ecc, *(calculate_ecc+1),
+ *(calculate_ecc), *(calculate_ecc+2));
+ if (err = 1)
+ strncpy(calculate_ecc, redundant_ecc, 3);
+
+ if (err = 0 || err = 1 || err = 2)
+ return 0;
+ return -1;
}
void _Calculate_D_SwECC(buf,ecc)
--
1.7.0.4
next reply other threads:[~2010-12-31 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 9:19 Javier Martinez Canillas [this message]
2010-12-31 10:17 ` [PATCH 2/4] staging: keucr: Use strncpy() instead of custom Dan Carpenter
2010-12-31 13:23 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293787164-7056-3-git-send-email-martinez.javier@gmail.com \
--to=martinez.javier@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox