From: Joe Perches <joe@perches.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: keucr: Use memcmp() instead custom
Date: Sun, 02 Jan 2011 21:25:21 +0000 [thread overview]
Message-ID: <1294003521.23422.23.camel@Joe-Laptop> (raw)
In-Reply-To: <1294002097-3058-2-git-send-email-martinez.javier@gmail.com>
On Sun, 2011-01-02 at 22:21 +0100, Javier Martinez Canillas wrote:
> > This code isn't the same.
> > You deleted that return and now you do the driver ECC check.
> > Is that correct?
> You are right Joe, sorry for that. Should I remove the dead code after
> the return SUCCESS or keep it?
As I said before, I think you should delete it.
On Fri, 2010-12-31 at 12:26 -0800, Joe Perches wrote:
> You might as well take out useless code after returns
> instead of just changing function names.
> If you keep it you should reformat it.
Doesn't matter much though.
cheers, Joe
prev parent reply other threads:[~2011-01-02 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 21:01 [PATCH 1/3] staging: keucr: Use memcmp() instead custom StringCmp() and some style cleanups Javier Martinez Canillas
2011-01-02 21:10 ` [PATCH 1/3] staging: keucr: Use memcmp() instead custom Joe Perches
2011-01-02 21:21 ` Javier Martinez Canillas
2011-01-02 21:25 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294003521.23422.23.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox