From: Joe Perches <joe@perches.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: xgfib: put parenthesis in the right place
Date: Tue, 04 Jan 2011 05:20:02 +0000 [thread overview]
Message-ID: <1294118402.6617.8.camel@Joe-Laptop> (raw)
In-Reply-To: <20110104045807.GZ1886@bicker>
On Tue, 2011-01-04 at 07:58 +0300, Dan Carpenter wrote:
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> @@ -3954,7 +3954,7 @@ void XGI_GetCRT2ResInfo(unsigned short ModeNo, unsigned short ModeIdIndex,
> unsigned char XGI_IsLCDDualLink(struct vb_device_info *pVBInfo)
> {
>
> - if ((((pVBInfo->VBInfo & SetCRT2ToLCD) | SetCRT2ToLCDA))
> + if ((pVBInfo->VBInfo & (SetCRT2ToLCD | SetCRT2ToLCDA))
> && (pVBInfo->LCDInfo & SetLCDDualLink)) /* shampoo0129 */
Perhaps more legible and standard as:
if ((pVBInfo->VBInfo & (SetCRT2ToLCD | SetCRT2ToLCDA)) &&
(pVBInfo->LCDInfo & SetLCDDualLink))
prev parent reply other threads:[~2011-01-04 5:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 4:58 [patch] Staging: xgfib: put parenthesis in the right place Dan Carpenter
2011-01-04 5:20 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294118402.6617.8.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox