From: Johannes Berg <johannes@sipsolutions.net>
To: Julia Lawall <julia@diku.dk>
Cc: kernel-janitors@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net/wireless/nl80211.c: Avoid call to
Date: Fri, 28 Jan 2011 14:20:05 +0000 [thread overview]
Message-ID: <1296224405.5118.8.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1101281515410.8546@pc-004.diku.dk>
On Fri, 2011-01-28 at 15:16 +0100, Julia Lawall wrote:
> > But why did you call the label differently? :)
>
> Because out is already used in this case, and I didn't want to change all
> of the other occurrences of nla_put_failure. It's a bit sloppy though,
> because this code is the actual nla_put_failure. I can change it if you
> prefer.
Oh, and I could've seen that from the patch itself too, I just missed
it, sorry.
johannes
prev parent reply other threads:[~2011-01-28 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 13:57 [PATCH 1/2] net/wireless/nl80211.c: Avoid call to genlmsg_cancel Julia Lawall
2011-01-28 14:01 ` [PATCH 1/2] net/wireless/nl80211.c: Avoid call to Johannes Berg
2011-01-28 14:16 ` [PATCH 1/2] net/wireless/nl80211.c: Avoid call to genlmsg_cancel Julia Lawall
2011-01-28 14:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296224405.5118.8.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox