From: Liam Girdwood <lrg@kernel.org>
To: Dan Carpenter <error27@gmail.com>, Samuel Ortiz <sameo@linux.intel.com>
Cc: Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
open list <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] regulator/tps65912: storing error codes in u8
Date: Mon, 04 Jul 2011 16:06:58 +0000 [thread overview]
Message-ID: <1309795618.3272.9.camel@odin> (raw)
In-Reply-To: <20110623055715.GM14591@shale.localdomain>
On Thu, 2011-06-23 at 08:57 +0300, Dan Carpenter wrote:
> get_ctrl_reg() returns -EINVAL so the error handling won't work here
> if reg is a u8.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
> index d2c6542..3a9313e 100644
> --- a/drivers/regulator/tps65912-regulator.c
> +++ b/drivers/regulator/tps65912-regulator.c
> @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
> struct tps65912_reg *pmic = rdev_get_drvdata(dev);
> struct tps65912 *mfd = pmic->mfd;
> int id = rdev_get_id(dev);
> - u8 reg;
> + int reg;
>
> if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
> return -EINVAL;
Samuel, would you mind taking this since tps65912 is upstreaming via
mfd.
Thanks !
Liam
next prev parent reply other threads:[~2011-07-04 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 5:57 [patch] regulator/tps65912: storing error codes in u8 Dan Carpenter
2011-06-23 10:35 ` Mark Brown
2011-07-04 16:06 ` Liam Girdwood [this message]
2011-07-06 18:32 ` Samuel Ortiz
2011-07-06 18:57 ` Dan Carpenter
2011-07-06 19:07 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309795618.3272.9.camel@odin \
--to=lrg@kernel.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox