From: Julia Lawall <julia@diku.dk>
To: Ohad Ben-Cohen <ohad@wizery.com>, trivial@kernel.org
Cc: kernel-janitors@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 6/11] drivers/iommu/iommu.c: trivial: use BUG_ON
Date: Tue, 02 Aug 2011 10:34:59 +0000 [thread overview]
Message-ID: <1312281304-11847-7-git-send-email-julia@diku.dk> (raw)
In-Reply-To: <1312281304-11847-1-git-send-email-julia@diku.dk>
From: Julia Lawall <julia@diku.dk>
Use BUG_ON(x) rather than if(x) BUG();
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@ identifier x; @@
-if (x) BUG();
+BUG_ON(x);
@@ identifier x; @@
-if (!x) BUG();
+BUG_ON(!x);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/iommu/iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -27,8 +27,7 @@ static struct iommu_ops *iommu_ops;
void register_iommu(struct iommu_ops *ops)
{
- if (iommu_ops)
- BUG();
+ BUG_ON(iommu_ops);
iommu_ops = ops;
}
next prev parent reply other threads:[~2011-08-02 10:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 10:34 [PATCH 0/11] trivial: use BUG_ON Julia Lawall
2011-08-02 10:34 ` [PATCH 1/11] kernel/kfifo.c: " Julia Lawall
2011-08-02 11:33 ` Andrea Righi
2011-08-02 11:52 ` Julia Lawall
2011-08-02 12:03 ` Andrea Righi
2011-08-02 15:20 ` Julia Lawall
2011-08-02 19:27 ` Julia Lawall
2011-08-02 20:09 ` Andrea Righi
2011-08-03 6:30 ` Stefani Seibold
2011-08-02 10:34 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: " Julia Lawall
2011-08-04 6:54 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use Nandigama, Nagalakshmi
2011-08-04 7:13 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use BUG_ON walter harms
2011-08-02 10:34 ` [PATCH 3/11] arch/arm/mach-s3c64xx/dma.c: " Julia Lawall
2011-08-02 10:34 ` [PATCH 4/11] arch/x86/kvm/vmx.c: " Julia Lawall
2011-08-02 16:44 ` Marcelo Tosatti
2011-08-02 10:34 ` [PATCH 5/11] kernel/sysctl.c: " Julia Lawall
2011-08-02 10:34 ` Julia Lawall [this message]
2011-08-02 10:35 ` [PATCH 7/11] arch/m32r/kernel/smp.c: " Julia Lawall
2011-08-02 10:55 ` KOSAKI Motohiro
2011-08-02 10:35 ` [PATCH 8/11] fs/btrfs/volumes.c: " Julia Lawall
2011-08-02 10:35 ` [PATCH 9/11] drivers/target/target_core_rd.c: " Julia Lawall
2011-08-04 18:05 ` [PATCH 9/11] drivers/target/target_core_rd.c: trivial: use Nicholas A. Bellinger
2011-08-02 10:35 ` [PATCH 10/11] arch/openrisc/mm/init.c: trivial: use BUG_ON Julia Lawall
2011-08-02 13:55 ` Jonas Bonn
2011-08-02 10:35 ` [PATCH 11/11] arch/tile/mm/init.c: " Julia Lawall
2011-08-02 20:28 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312281304-11847-7-git-send-email-julia@diku.dk \
--to=julia@diku.dk \
--cc=joerg.roedel@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox