public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: kernel-janitors@vger.kernel.org,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Lucas De Marchi <lucas.demarchi@profusion.mobi>,
	Jean Delvare <khali@linux-fr.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] drivers/media/video/hexium_gemini.c: delete useless initialization
Date: Thu, 04 Aug 2011 10:29:33 +0000	[thread overview]
Message-ID: <1312453774-23333-4-git-send-email-julia@diku.dk> (raw)
In-Reply-To: <1312453774-23333-1-git-send-email-julia@diku.dk>

From: Julia Lawall <julia@diku.dk>

Delete nontrivial initialization that is immediately overwritten by the
result of an allocation function.

The semantic match that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
identifier i;
expression e;
@@

(
T i = \(0\|NULL\|ERR_PTR(...)\);
|
-T i = e;
+T i;
)
... when != i
i = \(kzalloc\|kcalloc\|kmalloc\)(...);

// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/media/video/hexium_gemini.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/drivers/media/video/hexium_gemini.c b/drivers/media/video/hexium_gemini.c
--- a/drivers/media/video/hexium_gemini.c
+++ b/drivers/media/video/hexium_gemini.c
@@ -352,7 +352,7 @@ static struct saa7146_ext_vv vv_data;
 /* this function only gets called when the probing was successful */
 static int hexium_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_data *info)
 {
-	struct hexium *hexium = (struct hexium *) dev->ext_priv;
+	struct hexium *hexium;
 	int ret;
 
 	DEB_EE((".\n"));


  parent reply	other threads:[~2011-08-04 10:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 10:29 [PATCH 0/4] delete useless initialization Julia Lawall
2011-08-04 10:29 ` [PATCH 1/4] fs/ext3/balloc.c: " Julia Lawall
2011-08-04 10:40   ` Jan Kara
2011-08-04 10:29 ` [PATCH 2/4] fs/ext2/balloc.c: " Julia Lawall
2011-08-04 10:39   ` Jan Kara
2011-08-04 10:29 ` Julia Lawall [this message]
2011-08-16 11:55   ` [PATCH 3/4] drivers/media/video/hexium_gemini.c: delete useless Jean Delvare
2011-08-04 10:29 ` [PATCH 4/4] drivers/leds/leds-pca9532.c: delete useless initialization Julia Lawall
2011-08-05 22:37   ` [PATCH 4/4] drivers/leds/leds-pca9532.c: delete useless Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312453774-23333-4-git-send-email-julia@diku.dk \
    --to=julia@diku.dk \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=mchehab@infradead.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox