From: Dan Williams <dcbw@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Daniel Drake <dsd@laptop.org>,
"John W. Linville" <linville@tuxdriver.com>,
"open list:MARVELL LIBERTAS..."
<libertas-dev@lists.infradead.org>,
"open list:NETWORKING [WIREL..." <linux-wireless@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] libertas: handle mesh networks in
Date: Mon, 15 Aug 2011 22:52:29 +0000 [thread overview]
Message-ID: <1313448751.6103.15.camel@dcbw.foobar.com> (raw)
In-Reply-To: <20110815112535.GC10560@shale.localdomain>
On Mon, 2011-08-15 at 14:25 +0300, Dan Carpenter wrote:
> There was an extra semicolon so the if condition wasn't used. We
> checked "priv->dev" twice instead of "priv->mesh_dev".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> Compile tested only.
>
> diff --git a/drivers/net/wireless/libertas/dev.h b/drivers/net/wireless/libertas/dev.h
> index 8148389..b9ff0dc 100644
> --- a/drivers/net/wireless/libertas/dev.h
> +++ b/drivers/net/wireless/libertas/dev.h
> @@ -190,8 +190,8 @@ static inline int lbs_iface_active(struct lbs_private *priv)
> int r;
>
> r = netif_running(priv->dev);
> - if (priv->mesh_dev);
> - r |= netif_running(priv->dev);
> + if (priv->mesh_dev)
> + r |= netif_running(priv->mesh_dev);
>
> return r;
> }
prev parent reply other threads:[~2011-08-15 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 11:25 [patch -next] libertas: handle mesh networks in lbs_iface_active() Dan Carpenter
2011-08-15 22:52 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313448751.6103.15.camel@dcbw.foobar.com \
--to=dcbw@redhat.com \
--cc=dsd@laptop.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox