From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Guy, Wey-Yi" Date: Wed, 31 Aug 2011 09:35:36 +0000 Subject: Re: [patch -next 2/2] iwlwifi: signedness bug in Message-Id: <1314783336.26890.4.camel@wwguy-huron> List-Id: References: <20110831063830.GD3705@shale.localdomain> In-Reply-To: <20110831063830.GD3705@shale.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "Grumbach, Emmanuel" , Intel Linux Wireless , "John W. Linville" , "open list:INTEL WIRELESS WI..." , "kernel-janitors@vger.kernel.org" On Tue, 2011-08-30 at 23:38 -0700, Dan Carpenter wrote: > unsigned shorts and unsigned chars are never = -1. > > Signed-off-by: Dan Carpenter Signed-off-by: Wey-Yi Guy > > diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c > index 5dd6a6d..ea6a0bc 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c > +++ b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c > @@ -535,7 +535,7 @@ int iwl_trans_pcie_tx_agg_alloc(struct iwl_trans *trans, > struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); > struct iwl_tid_data *tid_data; > unsigned long flags; > - u16 txq_id; > + int txq_id; > struct iwl_priv *priv = priv(trans); > > txq_id = iwlagn_txq_ctx_activate_free(trans); True Wey