From: Joe Perches <joe@perches.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 15/16] Staging: quickstart: Add QS_INFO and QS_ERR macros for logs
Date: Wed, 11 Jan 2012 20:51:32 +0000 [thread overview]
Message-ID: <1326315092.6774.6.camel@joe2Laptop> (raw)
In-Reply-To: <1326147815-11451-16-git-send-email-szymon@janc.net.pl>
On Wed, 2012-01-11 at 18:55 +0100, Szymon Janc wrote:
> > > #define QUICKSTART_PF_DRIVER_NAME "quickstart"
> > > #define QUICKSTART_PF_DEVICE_NAME "quickstart"
> > >
> > > +#define QS_INFO(fmt, arg...) printk(KERN_INFO "quickstart: " fmt "\n",
> > > ##arg) +#define QS_ERR(fmt, arg...) printk(KERN_ERR "quickstart: " fmt
> > > "\n", ##arg) +
> >
> > No. Don't do this. You can do same thing with pr_err() so you
> > don't need to create your own macros. Just add this to the front:
> >
> > #define pr_fmt(fmt) "quickstart: " fmt
> >
> > We already have a million standard ways of printing stuff, we don't
> > need a million and two.
>
> Ok, and thanks for review! I'll send V2 shortly.
Before you send V2, this is better as:
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
next prev parent reply other threads:[~2012-01-11 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:23 [PATCH 15/16] Staging: quickstart: Add QS_INFO and QS_ERR macros for logs Szymon Janc
2012-01-11 11:56 ` Dan Carpenter
2012-01-11 17:55 ` Szymon Janc
2012-01-11 20:51 ` Joe Perches [this message]
2012-01-11 22:22 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326315092.6774.6.camel@joe2Laptop \
--to=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox