From: Joe Perches <joe@perches.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 15/17] Staging: quickstart: Use pr_err and pr_info for logs
Date: Mon, 23 Jan 2012 17:44:53 +0000 [thread overview]
Message-ID: <1327340693.1704.6.camel@joe2Laptop> (raw)
In-Reply-To: <1326320574-11220-17-git-send-email-szymon@janc.net.pl>
On Mon, 2012-01-23 at 14:13 -0200, Jorgyano Bruno wrote:
> (an html formatted reply)
html emails are rejected by kernel.org lists,
please use text-only.
> On Wed, Jan 11, 2012 at 9:58 PM, Joe Perches <joe@perches.com> wrote:
> It's OK to have the line with the format exceed 80 chars.
> What about the 80-columns rule?
> is the strings an exception to the rule?
> when we should not to break the strings over 80 columns?
Formats should be unbroken where possible.
80 column wrapping should be ignored for format strings.
An exception might be a multi-line format (with multiple newlines)
printk(KERN_LEVEL "long line 1\n"
"long line 2\n");
prev parent reply other threads:[~2012-01-23 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 22:22 [PATCH v2 15/17] Staging: quickstart: Use pr_err and pr_info for logs Szymon Janc
2012-01-11 23:58 ` Joe Perches
2012-01-14 22:20 ` Szymon Janc
2012-01-22 18:52 ` Szymon Janc
2012-01-23 17:44 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327340693.1704.6.camel@joe2Laptop \
--to=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox