From: "Dmitry Kravkov" <dmitry@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Eilon Greenstein <eilong@broadcom.com>,
Yuval Mintz <yuvalmin@broadcom.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bnx2x: unlock before returning an error
Date: Wed, 25 Jan 2012 08:14:54 +0000 [thread overview]
Message-ID: <1327479294.11041.3.camel@lb-tlvb-dmitry> (raw)
In-Reply-To: <20120125075931.GA20199@elgon.mountain>
On Wed, 2012-01-25 at 10:59 +0300, Dan Carpenter wrote:
> We introduced a new return here but forgot to drop the lock.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index cb6339c..69465c3 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -1836,6 +1836,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,
> rc = exeq->remove(bp, exeq->owner, exeq_pos);
> if (rc) {
> BNX2X_ERR("Failed to remove command\n");
> + spin_unlock_bh(&exeq->lock);
> return rc;
> }
> list_del(&exeq_pos->link);
> --
Thank you, Dan.
Acked-by: Dmitry Kravkov <dmitry@broadcom.com>
next prev parent reply other threads:[~2012-01-25 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 7:59 [patch -next] bnx2x: unlock before returning an error Dan Carpenter
2012-01-25 8:14 ` Dmitry Kravkov [this message]
2012-01-25 21:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327479294.11041.3.camel@lb-tlvb-dmitry \
--to=dmitry@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=eilong@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox