From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Kravkov" Date: Wed, 25 Jan 2012 08:14:54 +0000 Subject: Re: [patch -next] bnx2x: unlock before returning an error Message-Id: <1327479294.11041.3.camel@lb-tlvb-dmitry> List-Id: References: <20120125075931.GA20199@elgon.mountain> In-Reply-To: <20120125075931.GA20199@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Eilon Greenstein , Yuval Mintz , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, 2012-01-25 at 10:59 +0300, Dan Carpenter wrote: > We introduced a new return here but forgot to drop the lock. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c > index cb6339c..69465c3 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c > @@ -1836,6 +1836,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp, > rc = exeq->remove(bp, exeq->owner, exeq_pos); > if (rc) { > BNX2X_ERR("Failed to remove command\n"); > + spin_unlock_bh(&exeq->lock); > return rc; > } > list_del(&exeq_pos->link); > -- Thank you, Dan. Acked-by: Dmitry Kravkov