From: Joe Perches <joe@perches.com>
To: dedekind1@gmail.com
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Michal Marek <mmarek@suse.cz>,
Gilles Muller <Gilles.Muller@lip6.fr>,
bruce.w.allan@intel.com, rusty@rustcorp.com.au,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
cocci@diku.dk, Julia Lawall <julia@diku.dk>
Subject: Re: [Cocci] Re: [PATCH] scripts/coccinelle/misc/boolinit.cocci: semantic patch for bool issues
Date: Fri, 10 Feb 2012 18:51:01 +0000 [thread overview]
Message-ID: <1328899861.14197.7.camel@joe2Laptop> (raw)
In-Reply-To: <1328899454.22240.91.camel@sauron.fi.intel.com>
On Fri, 2012-02-10 at 20:44 +0200, Artem Bityutskiy wrote:
> On Fri, 2012-02-10 at 09:45 -0800, Joe Perches wrote:
> > On Fri, 2012-02-10 at 18:11 +0100, Julia Lawall wrote:
> > > From: Julia Lawall <Julia.Lawall@lip6.fr>
> > Thanks Julia. It seems to work well.
> I wonder though, why would we want to change if (a = true) with if (a)
> etc? Julia did not provide the explanation in the commit message but
> referred to you and Rusty in the semantic patch.
Testing booleans against specific values is poor form.
booleans should be tested or !tested.
If you are going to submit these patches,
I suggest you break them out by 2nd level
directory.
patch 1: drivers/foo/...
patch 2: drivers/bar/...
...
patch n: drivers/baz/...
and cc: trivial@kernel.org
next prev parent reply other threads:[~2012-02-10 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 17:11 [PATCH] scripts/coccinelle/misc/boolinit.cocci: semantic patch for bool issues Julia Lawall
2012-02-10 17:45 ` Joe Perches
2012-02-10 18:38 ` [Cocci] " Artem Bityutskiy
2012-02-10 18:44 ` Artem Bityutskiy
2012-02-10 18:51 ` Joe Perches [this message]
2012-02-10 18:55 ` Artem Bityutskiy
2012-02-10 19:03 ` Artem Bityutskiy
2012-02-10 19:04 ` [Cocci] " Artem Bityutskiy
2012-02-10 20:19 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328899861.14197.7.camel@joe2Laptop \
--to=joe@perches.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=bruce.w.allan@intel.com \
--cc=cocci@diku.dk \
--cc=dedekind1@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox