public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhengwang Ruan <ruan.zhengwang@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool
Date: Mon, 27 Feb 2012 10:17:50 +0000	[thread overview]
Message-ID: <1330337871-27830-1-git-send-email-ruan.zhengwang@gmail.com> (raw)

GCC warns that module_param_named() indirectly returns a bool type value
which is different from 'int' type binder_debug_no_lock declared. Change
it to bool because it is a internal switch for debugging.

Signed-off-by: Zhengwang Ruan <ruan.zhengwang@gmail.com>
---
v2: added a subsystem prefix to the subject
---
 drivers/staging/android/binder.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index f0b7e66..4350425 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -103,7 +103,7 @@ static uint32_t binder_debug_mask = BINDER_DEBUG_USER_ERROR |
 	BINDER_DEBUG_FAILED_TRANSACTION | BINDER_DEBUG_DEAD_TRANSACTION;
 module_param_named(debug_mask, binder_debug_mask, uint, S_IWUSR | S_IRUGO);
 
-static int binder_debug_no_lock;
+static bool binder_debug_no_lock;
 module_param_named(proc_no_lock, binder_debug_no_lock, bool, S_IWUSR | S_IRUGO);
 
 static DECLARE_WAIT_QUEUE_HEAD(binder_user_error_wait);
-- 
1.6.0.4


             reply	other threads:[~2012-02-27 10:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27 10:17 Zhengwang Ruan [this message]
2012-03-07  2:36 ` [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool Zhengwang Ruan
2012-03-07  2:36   ` [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used Zhengwang Ruan
2012-03-07  4:01     ` Arve Hjønnevåg
2012-03-07  4:58       ` Zhengwang Ruan
2012-03-07  5:46     ` Greg KH
2012-03-07  6:16       ` Zhengwang Ruan
2012-03-07  5:58     ` Dan Carpenter
2012-03-07  6:01       ` Zhengwang Ruan
2012-03-07  6:20         ` Dan Carpenter
2012-03-07  6:25           ` Zhengwang Ruan
2012-03-07  2:49 ` [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool ruan.zhengwang
2012-03-07  2:49   ` [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used ruan.zhengwang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330337871-27830-1-git-send-email-ruan.zhengwang@gmail.com \
    --to=ruan.zhengwang@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox