Re: [PATCH] Bluetooth: Silence static checker warning.

Dan Carpenter
2012-03-02T11:04:20Z

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On Fri, Mar 02, 2012 at 09:15:37AM -0000, David Laight wrote:
> How long has this code been in tree?
> It isn't obvious to me that this change won't break code on BE systems
> where the application code is already fixing the endianness.
>

It looks like we've had an endian bug since last February.

b62f328b8f20a "Bluetooth: Add server socket support for LE
connection"

+ l2cap_pi(sk)->scid = la.l2_cid;

->scid was cpu endian.

regards,
dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]