Re: [PATCH] Bluetooth: Silence static checker warning.

Marcel Holtmann
2012-03-02T17:57:06Z

Hi Dan,

> > How long has this code been in tree?
> > It isn't obvious to me that this change won't break code on BE systems
> > where the application code is already fixing the endianness.
> >
>
> It looks like we've had an endian bug since last February.
>
> b62f328b8f20a "Bluetooth: Add server socket support for LE
> connection"
>
> + l2cap_pi(sk)->scid = la.l2_cid;
>
> ->scid was cpu endian.

this is a bug. No questions asked.

However you can only exercise this code if you work with Bluetooth Low
Energy and that is not enabled by default since it is not fully finished
yet. CID is only used by Low Energy.

Bluetooth BR/EDR only uses PSM part of the socket address and that has
been endian safe.

Regards

Marcel