From: Emil Goode <emilgoode@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern
Date: Fri, 02 Mar 2012 21:56:31 +0000 [thread overview]
Message-ID: <1330725391-9439-1-git-send-email-emilgoode@gmail.com> (raw)
sparse warns:
arch/x86/kernel/kprobes.c:1489:13: warning: function 'arch_unoptimize_kprobes' with external linkage has definition
This is my first patch which is why I'm sending it here first to see if I'm doing something wrong.
Any advice is greatly appreciated.
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
arch/x86/kernel/kprobes.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
index 7da647d..f55c28e 100644
--- a/arch/x86/kernel/kprobes.c
+++ b/arch/x86/kernel/kprobes.c
@@ -1486,8 +1486,8 @@ static void __kprobes setup_unoptimize_kprobe(struct text_poke_param *tprm,
* Recover original instructions and breakpoints from relative jumps.
* Caller must call with locking kprobe_mutex.
*/
-extern void arch_unoptimize_kprobes(struct list_head *oplist,
- struct list_head *done_list)
+void arch_unoptimize_kprobes(struct list_head *oplist,
+ struct list_head *done_list)
{
struct optimized_kprobe *op, *tmp;
int c = 0;
--
1.7.9.1
next reply other threads:[~2012-03-02 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 21:56 Emil Goode [this message]
2012-03-03 7:44 ` [PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern Dan Carpenter
2012-03-03 7:56 ` santosh prasad nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330725391-9439-1-git-send-email-emilgoode@gmail.com \
--to=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox