From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Andy Grover <agrover@redhat.com>,
Joern Engel <joern@logfs.org>, Roland Dreier <roland@kernel.org>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] target: remove improper externs
Date: Sun, 18 Mar 2012 00:59:24 +0000 [thread overview]
Message-ID: <1332032364.10203.289.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20120317131152.GA23316@elgon.mountain>
On Sat, 2012-03-17 at 16:11 +0300, Dan Carpenter wrote:
> These externs aren't needed and Sparse complains about them.
>
> drivers/target/iscsi/iscsi_target_nodeattrib.c:52:12: warning:
> function 'iscsit_na_dataout_timeout' with external linkage has
> definition
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied. Thanks Dan!
--nab
prev parent reply other threads:[~2012-03-18 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 13:11 [patch] target: remove improper externs Dan Carpenter
2012-03-18 0:59 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332032364.10203.289.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=agrover@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=hch@lst.de \
--cc=joern@logfs.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roland@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox