public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] target/iscsi: cleanup some allocation style issues
Date: Wed, 18 Apr 2012 07:15:16 +0000	[thread overview]
Message-ID: <1334733316.15333.5.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20120417063359.GF26756@elgon.mountain>

On Tue, 2012-04-17 at 09:33 +0300, Dan Carpenter wrote:
> We can use kcalloc() here instead of kzalloc().  It's better style and
> it has overflow checking built in.
> 
> Also -ENOMEM is the correct error code for allocation errors.  -1 means
> -EPERM.  None of the callers preserve the error codes so it doesn't
> matter except as a cleanup.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 

Also applied to lio-core.  I'll make sure to include these into the next
target-pending update.

Thanks Dan!

--nab


      reply	other threads:[~2012-04-18  7:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  6:33 [patch] target/iscsi: cleanup some allocation style issues Dan Carpenter
2012-04-18  7:15 ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334733316.15333.5.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox