* [PATCH 3/4] Staging: Comedi adv_pci1710: Combined two conditions
@ 2012-05-07 19:50 Tomas Melin
0 siblings, 0 replies; only message in thread
From: Tomas Melin @ 2012-05-07 19:50 UTC (permalink / raw)
To: kernel-janitors
Combined two if statements making the code cleaner, removing one level
of indentation.
Signed-off-by: Tomas Melin <tomas.melin@iki.fi>
---
drivers/staging/comedi/drivers/adv_pci1710.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
index ef8b429..9c17cd1 100644
--- a/drivers/staging/comedi/drivers/adv_pci1710.c
+++ b/drivers/staging/comedi/drivers/adv_pci1710.c
@@ -1167,12 +1167,11 @@ static int check_channel_list(struct comedi_device *dev,
for (i = 1, seglen = 1; i < n_chan; i++, seglen++) {
if (chanlist[0] = chanlist[i])
break; /* we detected a loop, stop */
- if (CR_CHAN(chanlist[i]) & 1)
- if (CR_AREF(chanlist[i]) = AREF_DIFF) {
- comedi_error(dev,
- "Odd channel cannot be differential input!\n");
- return 0;
- }
+ if ((CR_CHAN(chanlist[i]) & 1) &&
+ (CR_AREF(chanlist[i]) = AREF_DIFF)) {
+ comedi_error(dev, "Odd channel cannot be differential input!\n");
+ return 0;
+ }
nowmustbechan (CR_CHAN(chansegment[i - 1]) + 1) % s->n_chan;
if (CR_AREF(chansegment[i - 1]) = AREF_DIFF)
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-07 19:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-07 19:50 [PATCH 3/4] Staging: Comedi adv_pci1710: Combined two conditions Tomas Melin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).