From: Kay Sievers <kay@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] printk: remove some dead code
Date: Tue, 03 Jul 2012 19:34:21 +0000 [thread overview]
Message-ID: <1341344061.1716.3.camel@mop> (raw)
In-Reply-To: <20120703104511.GA29501@elgon.mountain>
On Tue, 2012-07-03 at 20:43 +0200, walter harms wrote:
> > } else {
> > len += 3;
> > - if (msg->level > 9)
> > + if (prefix > 9)
> > len++;
> > - if (msg->level > 99)
> > + if (prefix > 99)
> > len++;
> > }
> > }
> >
> >
>
> just for my curiosity: why not len+=5 and forget the rest ?
It's a possibly multi-digit decimal number, and the length should be
actual length not the maximum.
Kay
prev parent reply other threads:[~2012-07-03 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 10:45 [patch] printk: remove some dead code Dan Carpenter
2012-07-03 11:21 ` Kay Sievers
2012-07-03 17:59 ` Kay Sievers
2012-07-03 18:43 ` walter harms
2012-07-03 19:34 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341344061.1716.3.camel@mop \
--to=kay@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox