From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [patch 1/2] memstick: use after free in msb_disk_release()
Date: Sat, 29 Sep 2012 22:09:14 +0000 [thread overview]
Message-ID: <1348956554.7401.1.camel@maxim-laptop> (raw)
In-Reply-To: <20120929071104.GB10993@elgon.mountain>
On Sat, 2012-09-29 at 10:11 +0300, Dan Carpenter wrote:
> The original code dereferenced "msb" after freeing it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
> index c815fe5..a8e8915 100644
> --- a/drivers/memstick/core/ms_block.c
> +++ b/drivers/memstick/core/ms_block.c
> @@ -1983,9 +1983,9 @@ static int msb_disk_release(struct gendisk *disk)
> msb->usage_count--;
>
> if (!msb->usage_count) {
> - kfree(msb);
> disk->private_data = NULL;
> idr_remove(&msb_disk_idr, msb->disk_id);
> + kfree(msb);
> put_disk(disk);
> }
> }
Oops, I added this bug in latest iteration, when removed support for
major.
Acked-by: Maxim Levitsky <maximlevitsly@gmail.com>
Best regards,
Maxim Levitsky
prev parent reply other threads:[~2012-09-29 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 7:11 [patch 1/2] memstick: use after free in msb_disk_release() Dan Carpenter
2012-09-29 22:09 ` Maxim Levitsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348956554.7401.1.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox