From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxim Levitsky <maximlevitsky@gmail.com>
Date: Sat, 29 Sep 2012 22:10:16 +0000
Subject: Re: [patch 2/2] memstick: memory leak on error in msb_ftl_scan()
Message-Id: <1348956616.7401.2.camel@maxim-laptop>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20120929071138.GC10993@elgon.mountain>
In-Reply-To: <20120929071138.GC10993@elgon.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Jens Axboe <axboe@kernel.dk>

On Sat, 2012-09-29 at 10:11 +0300, Dan Carpenter wrote: 
> We need to free "overwrite_flags" before returning.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
> index a8e8915..1f9d5cf 100644
> --- a/drivers/memstick/core/ms_block.c
> +++ b/drivers/memstick/core/ms_block.c
> @@ -1408,8 +1408,10 @@ static int msb_ftl_scan(struct msb_data *msb)
>  			msb_mark_block_used(msb, pba);
>  			msb_erase_block(msb, pba);
>  			continue;
> -		} else if (error)
> +		} else if (error) {
> +			kfree(overwrite_flags);
>  			return error;
> +		}
>  
>  		lba = be16_to_cpu(extra.logical_address);
>  		managment_flag = extra.management_flag;

Indeed. I need to be more careful with this,
I'll do another review of the code, maybe I spot anything else.

Acked-by: Maxim Levitsky <maximlevitsly@gmail.com>

Best regards,
Maxim Levitsky