From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] target: remove duplicate initialization
Date: Tue, 02 Oct 2012 20:24:05 +0000 [thread overview]
Message-ID: <1349209445.28145.62.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20121002082739.GF12398@elgon.mountain>
On Tue, 2012-10-02 at 11:27 +0300, Dan Carpenter wrote:
> We set bAlternateSetting to zero twice. I kept the second one
> (.bAlternateSetting = USB_G_ALT_INT_BBB) because that's more
> descriptive.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c
> index 0a83801..1ad4a69 100644
> --- a/drivers/usb/gadget/tcm_usb_gadget.c
> +++ b/drivers/usb/gadget/tcm_usb_gadget.c
> @@ -1956,7 +1956,6 @@ static void usbg_deregister_configfs(void)
> static struct usb_interface_descriptor bot_intf_desc = {
> .bLength = sizeof(bot_intf_desc),
> .bDescriptorType = USB_DT_INTERFACE,
> - .bAlternateSetting = 0,
> .bNumEndpoints = 2,
> .bAlternateSetting = USB_G_ALT_INT_BBB,
> .bInterfaceClass = USB_CLASS_MASS_STORAGE,
> --
Looks fine, applied to target-pending/for-next
Thanks Dan!
--nab
prev parent reply other threads:[~2012-10-02 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 8:27 [patch 1/2] target: remove duplicate initialization Dan Carpenter
2012-10-02 20:24 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349209445.28145.62.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox