From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] target: strlen() doesn't count the terminator
Date: Tue, 02 Oct 2012 20:24:46 +0000 [thread overview]
Message-ID: <1349209486.28145.63.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20121002082714.GE12398@elgon.mountain>
On Tue, 2012-10-02 at 11:27 +0300, Dan Carpenter wrote:
> We need to take the terminator into consideration here or the last
> character gets silently truncated away later.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c
> index 1ad4a69..97e68b3 100644
> --- a/drivers/usb/gadget/tcm_usb_gadget.c
> +++ b/drivers/usb/gadget/tcm_usb_gadget.c
> @@ -1812,7 +1812,7 @@ static ssize_t tcm_usbg_tpg_store_nexus(
> ret = tcm_usbg_drop_nexus(tpg);
> return (!ret) ? count : ret;
> }
> - if (strlen(page) > USBG_NAMELEN) {
> + if (strlen(page) >= USBG_NAMELEN) {
> pr_err("Emulated NAA Sas Address: %s, exceeds"
> " max: %d\n", page, USBG_NAMELEN);
> return -EINVAL;
> --
Also applied to for-next.
Thanks Dan !
--nab
prev parent reply other threads:[~2012-10-02 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 8:27 [patch 2/2] target: strlen() doesn't count the terminator Dan Carpenter
2012-10-02 20:24 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349209486.28145.63.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox