From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Navet Date: Wed, 12 Dec 2012 13:54:10 +0000 Subject: [PATCH] drivers: nouveau: Bool tests don't need comparison Message-Id: <1355320451-23292-1-git-send-email-laurent.navet@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: bskeggs@redhat.com, dri-devel@lists.freedesktops.org, airlied@linux.ie, kernel-janitors@vger.kernel.org, Laurent Navet Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan. The semantic patch that makes this output is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Laurent Navet --- drivers/gpu/drm/nouveau/core/subdev/timer/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/timer/base.c b/drivers/gpu/drm/nouveau/core/subdev/timer/base.c index 5d417cc..de6d6b7 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/timer/base.c +++ b/drivers/gpu/drm/nouveau/core/subdev/timer/base.c @@ -72,7 +72,7 @@ nouveau_timer_wait_cb(void *obj, u64 nsec, bool (*func)(void *), void *data) time0 = ptimer->read(ptimer); do { - if (func(data) = true) + if (func(data)) return true; } while (ptimer->read(ptimer) - time0 < nsec); -- 1.7.10.4