public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Emil Goode <emilgoode@gmail.com>
To: patricechotard@free.fr, martin.blumenstingl@googlemail.com,
	gregkh@linuxfoundation.org, crope@iki.fi
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Emil Goode <emilgoode@gmail.com>
Subject: [PATCH] [media] ngene: Use newly created function
Date: Sun, 06 Jan 2013 20:59:12 +0000	[thread overview]
Message-ID: <1357505952-14439-1-git-send-email-emilgoode@gmail.com> (raw)

The function demod_attach_drxd was split into two by commit 36a495a3.
This resulted in a new function tuner_attach_dtt7520x that is not used.
We should register tuner_attach_dtt7520x as a callback in the ngene_info
struct in the same way as done with the other part of the split function.

Sparse warning:

drivers/media/pci/ngene/ngene-cards.c:333:12: warning:
        ‘tuner_attach_dtt7520x’ defined but not used [-Wunused-function]

Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
This patch is a guess at what was intended. I'm not familiar with this code
and I don't have the hardware to test it.

 drivers/media/pci/ngene/ngene-cards.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/pci/ngene/ngene-cards.c b/drivers/media/pci/ngene/ngene-cards.c
index c99f779..60605c8 100644
--- a/drivers/media/pci/ngene/ngene-cards.c
+++ b/drivers/media/pci/ngene/ngene-cards.c
@@ -732,6 +732,7 @@ static struct ngene_info ngene_info_terratec = {
 	.name           = "Terratec Integra/Cinergy2400i Dual DVB-T",
 	.io_type        = {NGENE_IO_TSIN, NGENE_IO_TSIN},
 	.demod_attach   = {demod_attach_drxd, demod_attach_drxd},
+	.tuner_attach   = {tuner_attach_dtt7520x, tuner_attach_dtt7520x},
 	.fe_config      = {&fe_terratec_dvbt_0, &fe_terratec_dvbt_1},
 	.i2c_access     = 1,
 };
-- 
1.7.10.4


             reply	other threads:[~2013-01-06 20:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-06 20:59 Emil Goode [this message]
2013-01-06 21:12 ` [PATCH] [media] ngene: Use newly created function Patrice Chotard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357505952-14439-1-git-send-email-emilgoode@gmail.com \
    --to=emilgoode@gmail.com \
    --cc=crope@iki.fi \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=patricechotard@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox