From: Matt Fleming <matt.fleming@intel.com>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] x86, efi: precedence error in setup_efi_pci()
Date: Fri, 11 Jan 2013 13:52:38 +0000 [thread overview]
Message-ID: <1357912358.8203.316.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20121210084426.GQ22569@mwanda>
On Mon, 2012-12-10 at 11:44 +0300, Dan Carpenter wrote:
> On Fri, Dec 07, 2012 at 07:05:53PM -0800, H. Peter Anvin wrote:
> > On 12/06/2012 10:16 PM, Dan Carpenter wrote:
> > >Negate has higher precedence than bitwise AND so the condition is always
> > >false.
> > >
> > >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > >diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> > >index b1942e2..18e329c 100644
> > >--- a/arch/x86/boot/compressed/eboot.c
> > >+++ b/arch/x86/boot/compressed/eboot.c
> > >@@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
> > > if (status != EFI_SUCCESS)
> > > continue;
> > >
> > >- if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
> > >+ if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
> > > continue;
> > >
> > > if (!pci->romimage || !pci->romsize)
> > >
> >
> > What is the baseline for this patch?
> >
>
> Sorry, this is a linux-next bug. Introduced in:
>
> commit dd5fc854de5fd37adfcef8a366cd21a55aa01d3d
> Author: Matthew Garrett <mjg@redhat.com>
> Date: Wed Dec 5 14:33:26 2012 -0700
>
> EFI: Stash ROMs if they're not in the PCI BAR
Thanks Dan, I've picked this up.
prev parent reply other threads:[~2013-01-11 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 6:16 [patch] x86, efi: precedence error in setup_efi_pci() Dan Carpenter
[not found] ` <20121207061649.GA18220-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-12-08 3:05 ` H. Peter Anvin
[not found] ` <50C2AE91.9060800-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-12-10 8:44 ` Dan Carpenter
2013-01-11 13:52 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357912358.8203.316.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@intel.com \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox