From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Amit Mehta Date: Mon, 25 Mar 2013 05:37:48 +0000 Subject: [PATCH] staging: vme: fix for a potential NULL pointer dereference Message-Id: <1364189869-9275-1-git-send-email-gmate.amit@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: martyn.welch@ge.com Cc: manohar.vanga@gmail.com, gregkh@linuxfoundation.org, yamanetoshi@gmail.com, joe@perches.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Audit the return value of cdev_alloc and hence fixes a potential NULL pointer dereferencing. Signed-off-by: Kumar Amit Mehta --- drivers/staging/vme/devices/vme_user.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index d074b1e..da7f759 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -710,6 +710,10 @@ static int vme_user_probe(struct vme_dev *vdev) /* Register the driver as a char device */ vme_user_cdev = cdev_alloc(); + if (!vme_user_cdev) { + err = -ENOMEM; + goto err_char; + } vme_user_cdev->ops = &vme_user_fops; vme_user_cdev->owner = THIS_MODULE; err = cdev_add(vme_user_cdev, MKDEV(VME_MAJOR, 0), VME_DEVS); -- 1.7.9.5