Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED

Joe Perches
2013-08-09T16:28:06Z

On Fri, 2013-08-09 at 17:53 +0200, Peter Senna Tschudin wrote:
> On Fri, Aug 9, 2013 at 5:14 PM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2013-08-09 at 15:15 +0200, Peter Senna Tschudin wrote:
> >> Coccinelle (http://coccinelle.lip6.fr/) can help you in this task.
[]
> Peter's useful conversion won't find/convert cases where
> > IRQF_DISABLED is used in a #define like:
> >> diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c
> >> []
> >> @@ -915,7 +915,7 @@ static int ks_net_open(struct net_device *netdev)
> >> []
> >> -#define KS_INT_FLAGS (IRQF_DISABLED|IRQF_TRIGGER_LOW)
> >> +#define KS_INT_FLAGS (IRQF_TRIGGER_LOW)

Hi again.

> Coccinelle works with macros,

Sometimes yes. Perfectly? No.

> the problem in this specific case [...]

Other problems exist.
#include processing is troublesome.

> But, I would prefer to remove this define instead of patching it,
> seems to make more sense to me.

That'd be OK with me too.

Anyway, the point was not that coccinelle is bad.

Cocinelle's output, just like output from sed or
any other automated tool, still needs thoughtful
investigation and review.

(did I mention Coccinelle's a way cool tool?)

cheers, Joe