Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED

Kumar Gaurav
2013-08-09T02:36:52Z

On Friday 09 August 2013 03:03 AM, Joe Perches wrote:
> On Thu, 2013-08-08 at 14:20 -0700, David Miller wrote:
>> From: Dan Carpenter <dan.carpenter@oracle.com>
>> Date: Fri, 9 Aug 2013 00:09:18 +0300
>>
>>> On Fri, Aug 09, 2013 at 12:50:49AM +0530, Kumar Gaurav wrote:
>>>> Removed IRQF_DISABLED as it's no-op and should be removed
>>>>
>>> What? No, that doesn't sound right.
>> The IRQ layer completely ignores the flag for several releases
>> now, it's a complete no-op as his commit message so adequately
>> states.
>>
>> So what's the problem again? :-)
I'm quite new to kernel development. I saw in one of the patches which
fixes IRQF_DISABLED issue by removing so i did.
> Wouldn't it be better to do a sed 's/IRQF_DISABLED/0/' instead?
> Maybe Kumar wants to/is doing that?
Yes i wanted to do the same and i retrieved list of all programs
containing IRQF_DISABLED but i didn't wanted to send all of them in one
patch. I would be sending them for one program in one patch.

Regards
Kumar Gaurav