From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Sat, 10 Aug 2013 16:13:51 +0000 Subject: Re: [PATCH 1/5] drivers/gpio/gpio-omap.c: convert comma to semicolon Message-Id: <1376151231.2083.32.camel@joe-AO722> List-Id: References: <1376149225-3997-1-git-send-email-Julia.Lawall@lip6.fr> <1376149225-3997-2-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1376149225-3997-2-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Santosh Shilimkar , kernel-janitors@vger.kernel.org, Kevin Hilman , Linus Walleij , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote: > From: Julia Lawall > Replace a comma between expression statements by a semicolon. [] > I can't tell if the assignment to ct->regs.mask is really intended to be > under the if. The proposed patch preserves the current semantics, but not > the current indentation. I'd suspect more that the indentation is correct and the comma use incorrect. It also looks more like a copy/paste error from commit f8b46b583 when the code was restructured a bit. Kevin? -------------------- -#ifdef CONFIG_ARCH_OMAP16XX - /* REVISIT: assuming only 16xx supports MPUIO wake events */ - .irq_set_wake = gpio_wake_enable, -#endif -}; -------------------- + /* REVISIT: assuming only 16xx supports MPUIO wake events */ + if (cpu_is_omap16xx()) + ct->chip.irq_set_wake = gpio_wake_enable, -------------------- > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c [] > @@ -1029,10 +1029,10 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start, > ct->chip.irq_unmask = irq_gc_mask_clr_bit; > ct->chip.irq_set_type = gpio_irq_type; > > - if (bank->regs->wkup_en) > - ct->chip.irq_set_wake = gpio_wake_enable, > - > - ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride; > + if (bank->regs->wkup_en) { > + ct->chip.irq_set_wake = gpio_wake_enable; > + ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride; > + }