From: Joe Perches <joe@perches.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH 2/5] crypto/camellia_generic.c: convert comma to semicolon
Date: Sat, 10 Aug 2013 16:19:17 +0000 [thread overview]
Message-ID: <1376151557.2083.35.camel@joe-AO722> (raw)
In-Reply-To: <1376149225-3997-3-git-send-email-Julia.Lawall@lip6.fr>
On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:
> Replace a comma between expression statements by a semicolon.
[]
> This patch is separate from the others because the code appears to be
> machine-generated.
It may have once been machine generated, but it's not now.
It's been modified several times by human generated patches.
> diff --git a/crypto/camellia_generic.c b/crypto/camellia_generic.c
[]
> @@ -388,7 +388,7 @@ static void camellia_setup_tail(u32 *subkey, u32 *subL, u32 *subR, int max)
[]
> - dw = subL[1] & subL[9],
> + dw = subL[1] & subL[9];
> subR[1] ^= rol32(dw, 1); /* modified for FLinv(kl2) */
Perhaps you can (auto?) fix the indentation
on the next line too?
> @@ -397,7 +397,7 @@ static void camellia_setup_tail(u32 *subkey, u32 *subL, u32 *subR, int max)
[]
> - dw = subL[1] & subL[17],
> + dw = subL[1] & subL[17];
> subR[1] ^= rol32(dw, 1); /* modified for FLinv(kl4) */
etc...
next prev parent reply other threads:[~2013-08-10 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 15:40 [PATCH 0/5] convert comma to semicolon Julia Lawall
2013-08-10 15:40 ` [PATCH 1/5] drivers/gpio/gpio-omap.c: " Julia Lawall
2013-08-10 16:13 ` Joe Perches
2013-08-12 16:15 ` Kevin Hilman
2013-08-16 15:13 ` Linus Walleij
2013-08-10 15:40 ` [PATCH 2/5] crypto/camellia_generic.c: " Julia Lawall
2013-08-10 16:19 ` Joe Perches [this message]
2013-08-10 16:25 ` Julia Lawall
2013-08-10 15:40 ` [PATCH 3/5] arch/x86/crypto/camellia_glue.c: " Julia Lawall
2013-08-10 15:40 ` [PATCH 4/5] trivial: " Julia Lawall
2013-08-10 15:40 ` [PATCH 5/5] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376151557.2083.35.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Julia.Lawall@lip6.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox