From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] nl80211: nl80211hdr_put() doesn't return an ERR_PTR
Date: Wed, 14 Aug 2013 11:56:21 +0000 [thread overview]
Message-ID: <1376481381.14574.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130814115001.GB8044@elgon.mountain>
On Wed, 2013-08-14 at 14:50 +0300, Dan Carpenter wrote:
> There are a few places which check nl80211hdr_put() for an ERR_PTR
> but actually it returns NULL on error and never error values. In
> nl80211_testmode_dump() the return wasn't checked at all so I have added
> one.
Err, wow. How did we do this?!
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is static checker stuff and I don't know the code well. I was
> especially not sure if I got the check right in nl80211_testmode_dump().
> Please review that bit carefully.
Yes, looks fine. I'll apply this for 3.11, thanks.
johannes
prev parent reply other threads:[~2013-08-14 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 11:50 [patch] nl80211: nl80211hdr_put() doesn't return an ERR_PTR Dan Carpenter
2013-08-14 11:56 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376481381.14574.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox