From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
kernel-janitors@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [alsa-devel] [patch] ASoC: Baytrail: fix error handling in sst_byt_dsp_init()
Date: Wed, 05 Mar 2014 19:18:29 +0000 [thread overview]
Message-ID: <1394047109.2314.29.camel@loki> (raw)
In-Reply-To: <20140305111157.GD16926@elgon.mountain>
On Wed, 2014-03-05 at 14:11 +0300, Dan Carpenter wrote:
> Calling "kfree(byt)" is a double free because that was allocated with
> devm_kzalloc(). There were a couple places which leak "byt->msg". That
> memory is allocated in msg_empty_list_init().
>
Thanks, we've just fixed this too but were not quicker than you for
upstreaming ;)
Acked-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
next prev parent reply other threads:[~2014-03-05 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:11 [patch] ASoC: Baytrail: fix error handling in sst_byt_dsp_init() Dan Carpenter
2014-03-05 19:18 ` Liam Girdwood [this message]
2014-03-06 4:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394047109.2314.29.camel@loki \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox