From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Q] Sending a large patch
Date: Wed, 14 May 2014 14:28:37 +0000 [thread overview]
Message-ID: <1400077717.18277.39.camel@thorin> (raw)
In-Reply-To: <CAAvxhqBUO2HSgZjw=H7=Bd2gdw=JSjAs2Lx8E7rrGw8uqieZAg@mail.gmail.com>
On Mit, 2014-05-14 at 15:07 +0100, Masaru Nomura wrote:
> >> Now, I'm cleaning up a file and it has over 100 warnings of line over
> >> 80 character issues. As the problem seems to be the same, I may
> >
> > And you are really sure that is more readable afterwards with the
> > additional line breaks?
>
> Well, my intention is to follow the coding style[1].
Of course.
> As far as I understand, we follow this for linux-code readability.
> (Of course, I think I shouldn't split/break a line in a bad way though.)
>
> Chap 2 says:
> The limit on the length of lines is 80 columns and this is a strongly
> preferred limit.
>
> Or are there any situations where we ignore over 80 characters?
There are maintainers who do not see it that strict.
(Probably) no one has problem if one reorganizes 130 character lines.
But if a line with just some printk() has 81 characters if doesn't help
readability/understandability if it is split just for the sake of the
limit.
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
prev parent reply other threads:[~2014-05-14 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 0:48 [Q] Sending a large patch Masaru Nomura
2014-05-14 7:35 ` Dan Carpenter
2014-05-14 10:47 ` Bernd Petrovitsch
2014-05-14 14:07 ` Masaru Nomura
2014-05-14 14:14 ` Dan Carpenter
2014-05-14 14:16 ` Masaru Nomura
2014-05-14 14:28 ` Bernd Petrovitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400077717.18277.39.camel@thorin \
--to=bernd@petrovitsch.priv.at \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox